use fold to sum private shares since we don't impl Sum for Scalar

Trust-Machines · Nov 25, 2024 · a535269 · a535269
1 parent 42e7014
commit a535269
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/v1.rs b/src/v1.rs
@@ -181,9 +181,7 @@ impl Party {
             return Err(DkgError::BadPrivateShares(bad_shares));
         }
 
-        for (_i, s) in private_shares.iter() {
-            self.private_key += s;
-        }
+        self.private_key = private_shares.values().fold(Scalar::zero(), |a, s| a + s);
         self.public_key = self.private_key * G;
 
         Ok(())

diff --git a/src/v2.rs b/src/v2.rs
@@ -168,10 +168,8 @@ impl Party {
         for key_id in &self.key_ids {
             self.private_keys.insert(*key_id, Scalar::zero());
             if let Some(shares) = private_shares.get(key_id) {
-                for (_sender, s) in shares {
-                    self.private_keys
-                        .insert(*key_id, self.private_keys[key_id] + s);
-                }
+                let secret = shares.values().fold(Scalar::zero(), |acc, s| acc + s);
+                self.private_keys.insert(*key_id, secret);
             } else {
                 warn!(
                     "no private shares for key_id {}, even though we checked for it above",