Fix bad public shares check #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djordon
reviewed
Dec 13, 2024
xoloki
force-pushed
the
fix-bad-public-shares-verify
branch
from
b545354 to
b5228e8
Compare
jferrant
approved these changes
Dec 20, 2024
…we check public shares add test where one signer has incorrect threshold use common code to check public shares
xoloki
force-pushed
the
fix-bad-public-shares-verify
branch
from
b5228e8 to
d9e9914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw an issue on
sBTCtestnet where a single signer with a bad threshold not only preventedDKGfrom completing, but also caused theCoordinatorto think that all signers were malicious. This was because the signers were checking the threshold when evaluatingDkgPublicShares, but theCoordinatorwas not.To fix this, move the public shares check to common code, and call it from everywhere.
Fixes #105