Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleaner sign share request implementation #114

Merged
merged 4 commits into from
Jan 14, 2025
Merged

fix: cleaner sign share request implementation #114

merged 4 commits into from
Jan 14, 2025

Conversation

djordon
Copy link
Contributor

@djordon djordon commented Dec 24, 2024

Description

This builds off of #107, which addressed #108.

Changes

  • Fixes an off-by-one error in the current implementation.
  • Simplifies the implementation of sign_share_request slightly.

Testing

I still need to test all of the conditions checked for in the sign_share_request function.

@djordon djordon requested a review from xoloki December 24, 2024 19:28
@djordon djordon self-assigned this Dec 24, 2024
xoloki
xoloki requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@xoloki xoloki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo a number of questions and suggestions. The naming of is_valid_request is the only critical one.

@xoloki xoloki self-requested a review January 14, 2025 15:22
djordon
djordon commented Jan 14, 2025
View reviewed changes
Copy link
Contributor Author

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@djordon djordon merged commit 612c023 into main Jan 14, 2025
5 checks passed
@djordon djordon deleted the cleaner-sign-share-request branch January 14, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoloki xoloki xoloki approved these changes

Assignees

@djordon djordon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djordon @xoloki