Correctly retrun true for empty input shapes in EntityGetter#isUnobst…

…ructed Vanilla will return true for empty shapes, so we should as well.
Tuinity · Jan 27, 2025 · ce4ee76 · ce4ee76
1 parent d31b151
commit ce4ee76
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/ca/spottedleaf/moonrise/mixin/collisions/EntityGetterMixin.java b/src/main/java/ca/spottedleaf/moonrise/mixin/collisions/EntityGetterMixin.java
@@ -74,7 +74,7 @@ default List<VoxelShape> getEntityCollisions(final Entity entity, AABB box) {
     @Overwrite
     default boolean isUnobstructed(final Entity entity, final VoxelShape voxel) {
         if (voxel.isEmpty()) {
-            return false;
+            return true;
         }
 
         final AABB singleAABB = ((CollisionVoxelShape)voxel).moonrise$getSingleAABBRepresentation();

diff --git a/src/main/java/ca/spottedleaf/moonrise/mixin/collisions/LevelMixin.java b/src/main/java/ca/spottedleaf/moonrise/mixin/collisions/LevelMixin.java
@@ -55,7 +55,7 @@ abstract class LevelMixin implements LevelAccessor, AutoCloseable {
     public boolean isUnobstructed(final Entity entity) {
         final AABB boundingBox = entity.getBoundingBox();
         if (CollisionUtil.isEmpty(boundingBox)) {
-            return false;
+            return true;
         }
 
         final List<Entity> entities = this.getEntities(