Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply BestieTemplate changes #38

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

datejada
Copy link
Member

@datejada datejada commented Jul 11, 2024

Pull request details

Describe the changes made in this pull request

Apply changes from the template

List of related issues or pull requests

Closes #34
Closes #32

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2b22862) to head (654e63b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           28        28           
=========================================
  Hits            28        28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada
Copy link
Member Author

The link checker is not passing because the file https://github.com/TulipaEnergy/TulipaProfileFitting.jl/blob/main/docs/src/90-contributing.md
from the template is not in the main repository yet. It won't fail after we merge

@datejada datejada merged commit 4de0ebc into TulipaEnergy:main Jul 11, 2024
4 of 5 checks passed
@datejada datejada deleted the 34-apply-bestie-template branch July 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement BestieTemplate.jl Change readme.dev & contributing to link to TulipaEnergyModel
1 participant