Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fetch() and AsyncFunction instead of <script> for unsandboxed extensions #157

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Use fetch() and AsyncFunction instead of <script> for unsandboxed extensions #157

merged 3 commits into from
Aug 22, 2023

Conversation

GarboMuffin
Copy link
Member

Closes #140

@GarboMuffin
Refactor ScratchX compatibility layer
b23fb1e
@GarboMuffin
Run unsandboxed extensions with fetch() and new AsyncFunction instead…
55cda82 
… of <script>

Benefits:
 - IIFE no longer needed
 - Extensions can await
 - Better error messages
Downsides:
 - CORS now required to load extensions
@GarboMuffin
Fix tests
6836209
@GarboMuffin GarboMuffin merged commit 9caca1c into develop Aug 22, 2023
2 checks passed
@GarboMuffin GarboMuffin deleted the modernize-loading branch August 22, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading extensions through fetch or XHR rather than script tags
1 participant
@GarboMuffin