CompatHelper: add new compat entry for Statistics at version 1.6, (keep existing compat) #108
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… existing compat)
github-actions
bot
force-pushed
the
compathelper/new_version/2023-10-29-00-09-57-635-01430926315
branch
from
ae47165
to
4537265
Compare
Project.toml
Outdated
| @@ -24,6 +24,7 @@ DataStructures = "0.18.3" | |||
| Distributions = "0.25" | |||
| MLJModelInterface = "1.6" | |||
| SpecialFunctions = "0.8, 0.9, 0.10, 1, 2" | |||
| Statistics = "1" | |||
There was a problem hiding this comment.
Should we follow the recommendation in https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958 and rather use
| Statistics = "1" | |
| Statistics = "1.6" |
?
There was a problem hiding this comment.
It depends. Will it be possible to install an older version of a stdlib than the Julia version? That post doesn't state explicitly. My guess is no, since an older version of the stdlib may depend on a newer language feature, since they were coupled in the past. If so, then I don't see any reason to prefer one way over the other.
If specifying the same bound as the version number is preferable, it would be nice if CompatHelper did this by default.
There was a problem hiding this comment.
These were basically my thoughts as well. I just assumed that maybe the announcement would be more trustworthy.
There was a problem hiding this comment.
Sure, we can go that route. I'll update the PRs accordingly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 11 11
Lines 867 867
=======================================
Hits 838 838
Misses 29 29 ☔ View full report in Codecov by Sentry. |
sethaxen
changed the title
delete-merged-branch
bot
deleted the
compathelper/new_version/2023-10-29-00-09-57-635-01430926315
branch
This pull request sets the compat entry for the
Statisticspackage to1.6.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.