Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for fakemon transmutation. #340

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Fenris2142
Copy link
Contributor

@Fenris2142 Fenris2142 commented Jul 26, 2022

Some notes:

  • Fakemon transmutation (called Special transmutation in code) Costs T10. Regular (Standard) transmutation can still be triggered by adding T1 to the transmute command obviously
  • Both special and standard transmutation use the same formula that was unchanged by this PR.
  • Special Transmutation requires one badge to have at least 11.0 Logarithmic inverse rarity.

No Unit tests have been written (yet). Problem is that you can't really transmute anything with an (near) empty badge database as none of the badges will come even close to 11.0 in log inverse rarity.

Things left to Discuss:

  • Is T10 an acceptable price for special transmutations or should it be higher/lower?
  • Should special transmutation use the same formula as standard transmutation?
  • Is a static check for Log Inverse Rarity 11.0 a good thing? Right now this means that every badge with 48 or fewer existing (280 badge species) are eligible for fakemon transmutation which sounds like a lot, but in reality probably isn't because 2 more runs with full dexes (Randomized Shield, Radical Red, ...) will push a lot of badges out of this threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant