-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TT-11532 added config option for the http server in mdcb 2.5.1 #284
Conversation
@sredxny If ssl for health check is enabled, we also need to update the scheme of liveliness and readiness probes. |
Also, is the PR tested by your QA? |
Co-authored-by: Komal Sukhani <[email protected]>
Co-authored-by: Komal Sukhani <[email protected]>
Good catch!! Pushed a change for this behavior. Regarding who will test...that is a good question I guess it should be someone with confidence testing in helm, I will ask this and come back to you |
Description
To be released as part of MDCB 2.5.1
Related Issue
TT-11532
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master
!master
branch (left side). Also, it would be best if you started your change off our latestmaster
.