Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-11532 added config option for the http server in mdcb 2.5.1 #284

Merged
merged 12 commits into from
May 28, 2024

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Apr 30, 2024

Description

To be released as part of MDCB 2.5.1

Related Issue

TT-11532

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sredxny sredxny marked this pull request as ready for review May 1, 2024 16:17
@sredxny sredxny requested a review from a team as a code owner May 1, 2024 16:17
@sredxny sredxny requested review from komalsukhani, olamilekan000, buraksekili and a team and removed request for a team May 1, 2024 16:17
@sredxny sredxny changed the title TT-11532 added config option for the http server in mdcb TT-11532 added config option for the http server in mdcb 2.5.1 May 3, 2024
@komalsukhani
Copy link
Collaborator

@sredxny If ssl for health check is enabled, we also need to update the scheme of liveliness and readiness probes.

@komalsukhani
Copy link
Collaborator

Also, is the PR tested by your QA?

@sredxny
Copy link
Contributor Author

sredxny commented May 13, 2024

@sredxny If ssl for health check is enabled, we also need to update the scheme of liveliness and readiness probes.

Good catch!! Pushed a change for this behavior. Regarding who will test...that is a good question I guess it should be someone with confidence testing in helm, I will ask this and come back to you

@sredxny sredxny requested a review from komalsukhani May 13, 2024 20:32
@singhpr singhpr merged commit 19324c9 into main May 28, 2024
6 checks passed
@singhpr singhpr deleted the TT-11532-add-ssl/tls-configs-for-http-server branch May 28, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants