-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TT-12112 Add the value annotations to tyk-stack and component helm charts #291
TT-12112 Add the value annotations to tyk-stack and component helm charts #291
Conversation
To support an automated reloading of the gateway or other components of the tyk stack a common approach is to utilize tools like reloader. Currently the helm charts don't support any kind of annotations on the deployment level.
2412354
to
351ddb6
Compare
Thank you @mgnisia for your contribution. We will review this shortly. |
@caroltyk Hi Carol, could you maybe take another look? that would be awesome. |
Hi @mgnisia The PR looks good to me but I'll pass this to the engineers and QA for testing first. Let me update here when it is planned for release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @mgnisia for the great contribution! The PR looks great to me!
However, bumping version
of the chart triggers release action. Can you please not bump versions of the charts?
Thanks for the update 🙂 will revert the version change beginning of next week 👍🏻 |
Good morning @buraksekili revert the changes. It would be awesome if you cloud take another look. 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me @mgnisia! thanks for the contribution 🙏 I'll hand over the PR for testing, which will be merged once the testing is finished. I'll let you know if any questions arise during the testing process. once again, thank you for your time and contribution
LGTM! @buraksekili we should proceed with merging this PR |
@buraksekili can you foresee when this PR will be merged? |
@mgnisia thanks for your contribution 🏅 your contribution is going to be released within the next release. |
Description
Add
annotations
variable to the values.yaml file of all relevant helm chartsRelated Issue
Motivation and Context
To support an automated reloading of the gateway or other components of the tyk stack a common approach is to utilize tools like reloader. Currently the helm charts don't support any kind of annotations on the deployment level.
Test Coverage For This Change
I have been templating the helm charts on my machine (
helm template
) with:The templating worked without any issues.
Screenshots (if appropriate)
Types of changes
Checklist
master
!master
branch (left side). Also, it would be best if you started your change off our latestmaster
.