Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-12407] MDCB improvements #302

Merged
merged 9 commits into from
Jul 1, 2024
Merged

Conversation

komalsukhani
Copy link
Collaborator

@komalsukhani komalsukhani commented Jun 19, 2024

Description

In MDCB chart,

  • Enable setting of security secret using k8s secret
  • Change default value of security secret
  • Add annotation to watch for mdcb secret in deployment
  • Move mdcb.probes.httpPort to mdcb.httpPort

Related Issue

TT-12407

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@komalsukhani komalsukhani requested a review from a team as a code owner June 19, 2024 14:49
@komalsukhani komalsukhani requested review from olamilekan000 and removed request for a team June 19, 2024 14:49
@komalsukhani komalsukhani changed the title [TT-12407] Enable setting of security secret using k8s secret [TT-12407] MDCB improvements Jun 20, 2024
@komalsukhani komalsukhani merged commit 6135f4e into main Jul 1, 2024
6 checks passed
@komalsukhani komalsukhani deleted the feat/TT-12407/secret_support branch July 1, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants