Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-9324] Removed unused secret fields and configmaps #80

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

buraksekili
Copy link
Member

Description

This PR removes unused secret fields and configmaps in the charts.

Related Issue

https://tyktech.atlassian.net/browse/TT-9324

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@buraksekili buraksekili marked this pull request as ready for review July 27, 2023 11:21
@buraksekili buraksekili requested a review from a team as a code owner July 27, 2023 11:21
@buraksekili buraksekili requested review from komalsukhani and removed request for a team July 27, 2023 11:21
@singhpr singhpr merged commit cee0e0f into main Aug 1, 2023
9 checks passed
@singhpr singhpr deleted the refactor/TT-9324/revise-secrets-configs branch August 1, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants