Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MDCB Data plane doc #94

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Update MDCB Data plane doc #94

merged 1 commit into from
Aug 10, 2023

Conversation

buraksekili
Copy link
Member

Description

Updates formatting issue on mdcb data plane chart doc

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@buraksekili buraksekili requested a review from a team as a code owner August 10, 2023 12:11
@buraksekili buraksekili requested review from andrei-tyk and removed request for a team August 10, 2023 12:11
caroltyk
caroltyk approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@caroltyk caroltyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update

@buraksekili buraksekili merged commit 2cf5176 into main Aug 10, 2023
9 checks passed
@buraksekili buraksekili deleted the buraksekili-patch-1 branch August 10, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroltyk caroltyk caroltyk approved these changes

@andrei-tyk andrei-tyk Awaiting requested review from andrei-tyk andrei-tyk is a code owner automatically assigned from TykTechnologies/operator-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buraksekili @caroltyk