Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-9741 Add containerSecurityContext #95

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

zalbiraw
Copy link
Member

@zalbiraw zalbiraw commented Aug 10, 2023

Description

Currently containerSecurityContext is not configurable. This is required as k8s and openshift versions require some of these values to be set.

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zalbiraw zalbiraw requested a review from a team as a code owner August 10, 2023 15:33
@zalbiraw zalbiraw requested review from komalsukhani and removed request for a team August 10, 2023 15:33
tyk-single-dc/values.yaml Outdated Show resolved Hide resolved
@caroltyk caroltyk changed the title Add containerSecurityContext TT-9741 Add containerSecurityContext Aug 14, 2023
components/tyk-dashboard/values.yaml Outdated Show resolved Hide resolved
tyk-single-dc/values.yaml Show resolved Hide resolved
components/tyk-enterprise-portal/values.yaml Show resolved Hide resolved
@komalsukhani
Copy link
Collaborator

@zalbiraw I also wanted to know how to test this PR. Justing validating securityContext values on deployment or we need to test it on openshift?

@zalbiraw
Copy link
Member Author

@komalsukhani yes verifying the values in the deployment is sufficient enough.

@singhpr singhpr merged commit a74cf3c into main Sep 13, 2023
9 checks passed
@singhpr singhpr deleted the TT-9741-add-containerSecurityContext branch September 13, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants