TT-9846 allow setting imagePullSecrets #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for charts that allow setting image.repository
buraksekili
reviewed
Aug 11, 2023
There was a problem hiding this comment.
@rakkhin thank you for this great contribution! Can you also update tyk-bootstrap component as well, just to be consistent across all components? Please let me know if you have any questions.
|
@buraksekili I didn't want to touch bootstrap since images for resources defined there are hardcoded. But if it's OK with you I can bring those in line with other components. |
@rakkhin you are right. let's keep them as it is. thank you again for the contribution. I'll move this ticket to QA |
caroltyk
changed the title
caroltyk
changed the title
buraksekili
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow setting
imagePullSecretsfor charts that allow settingimage.repositoryDescription
Some organizations deploying Tyk in their infrastructure may have policies in place that require use of docker proxy for all 3rd party images. Those proxies almost always will requires authentication, but Tyk helm charts doesn't have option to set
imagePullSecretsfor those that allow setting image repo, effectively blocking those organizations from using self-hosted Tyk deployments.Related Issue
Resolves #96
Motivation and Context
Setting
imagePullSecretsis required for orgs that use internal docker proxies with authentication.Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.