Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pump CI #695

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Fix pump CI #695

merged 4 commits into from
Jul 31, 2023

Conversation

tbuchaillot
Copy link
Contributor

@tbuchaillot tbuchaillot commented Jul 27, 2023 •
edited
Loading

Description

Fix GithubActions , removed 1.18 from CI pipeline since pump uses 1.19, uses the following fixes
TykTechnologies/github-actions#12
TykTechnologies/github-actions#13

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@tbuchaillot tbuchaillot changed the title removing go 1.18 from CI Fix pump CI Jul 31, 2023
@tbuchaillot tbuchaillot merged commit b538a89 into master Jul 31, 2023
10 checks passed
@tbuchaillot tbuchaillot deleted the fix/ci branch July 31, 2023 14:35
@tbuchaillot
Copy link
Contributor Author

/release to release-1.8

@tykbot
Copy link

tykbot bot commented Jul 31, 2023

Working on it! Note that it can take a few minutes.

@tykbot
Copy link

tykbot bot commented Jul 31, 2023

Still working...

tykbot bot pushed a commit that referenced this pull request Jul 31, 2023
@tbuchaillot
Fix pump CI (#695)
fb80f66 
* removing go 1.18 from CI

* trying test-params gha branch

* trying gha improvements

* using main branch on workflows

(cherry picked from commit b538a89)
@buger buger mentioned this pull request Jul 31, 2023
Merged
@tykbot
Copy link

tykbot bot commented Jul 31, 2023

@tbuchaillot Succesfully merged PR

buger added a commit that referenced this pull request Jul 31, 2023
@buger
Merging to release-1.8: Fix pump CI (#695)
9a97205 
Fix pump CI (#695)

* removing go 1.18 from CI

* trying test-params gha branch

* trying gha improvements

* using main branch on workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mativm02 mativm02 mativm02 approved these changes

@sredxny sredxny sredxny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbuchaillot @sredxny @mativm02