godocs

TykTechnologies · Oct 25, 2024 · 6d106df · 6d106df
1 parent 37b8971
commit 6d106df
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/ee/middleware/upstreambasicauth/middleware.go b/ee/middleware/upstreambasicauth/middleware.go
@@ -58,8 +58,8 @@ func (m *Middleware) Init() {
 	m.Logger().Debug("Initializing Upstream basic auth Middleware")
 }
 
-// ProcessRequest will handle the streaming functionality.
-func (m *Middleware) ProcessRequest(w http.ResponseWriter, r *http.Request, _ interface{}) (error, int) {
+// ProcessRequest will handle upstream basic auth.
+func (m *Middleware) ProcessRequest(_ http.ResponseWriter, r *http.Request, _ interface{}) (error, int) {
 	basicAuthConfig := m.Spec.UpstreamAuth.BasicAuth
 
 	upstreamBasicAuthProvider := Provider{

diff --git a/gateway/mw_upstream_basic_auth.go b/gateway/mw_upstream_basic_auth.go
@@ -14,10 +14,12 @@ type noopUpstreamBasicAuth struct {
 	*BaseMiddleware
 }
 
-func (d *noopUpstreamBasicAuth) ProcessRequest(w http.ResponseWriter, r *http.Request, _ interface{}) (error, int) {
+// ProcessRequest is noop implementation for upstream basic auth mw.
+func (d *noopUpstreamBasicAuth) ProcessRequest(_ http.ResponseWriter, r *http.Request, _ interface{}) (error, int) {
 	return nil, http.StatusOK
 }
 
+// EnabledForSpec will always return false for noopUpstreamBasicAuth.
 func (d *noopUpstreamBasicAuth) EnabledForSpec() bool {
 	if d.Spec.UpstreamAuth.BasicAuth.Enabled {
 		d.Logger().Error("Upstream basic auth is supported only in Tyk Enterprise Edition")
@@ -26,6 +28,7 @@ func (d *noopUpstreamBasicAuth) EnabledForSpec() bool {
 	return false
 }
 
+// Name returns the name of the mw.
 func (d *noopUpstreamBasicAuth) Name() string {
 	return "NooPUpstreamBasicAuth"
 }