[TT-5777] Fix JWK fetch doesn't support proxy configuration from environment (#4102) #6474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanfoster
force-pushed
the
fix-jwk-fetch-no-proxy
branch
4 times, most recently
from
9bd4c82
to
57bf8d7
Compare
jonathanfoster
force-pushed
the
fix-jwk-fetch-no-proxy
branch
from
57bf8d7
to
d626f5e
Compare
|
@jeffy-mathew Anything you need from me for the review? Happy to help however I can. |
jonathanfoster
force-pushed
the
fix-jwk-fetch-no-proxy
branch
2 times, most recently
from
e2eb983
to
ff91633
Compare
sedkis
approved these changes
Oct 29, 2024
jonathanfoster
force-pushed
the
fix-jwk-fetch-no-proxy
branch
from
0fd6594
to
5249eb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the JWT middleware that causes the JWK fetch process to not honor HTTP proxy environment variables.
Related Issue
Motivation and Context
In restricted corporate environments, it's common to require all HTTP traffic go through a proxy server. The default transport pulls proxy settings from the standard environment variables, but it looks like this was inadvertently removed to support disabling TLS cert verification when fetching JWK sets. This fix restores the ability to support standard proxy environment variables.
How This Has Been Tested
All JWT middleware unit tests pass. I didn't add unit tests for this functionality because
http.ProxyFromEnvironmentcaches the config making tests that rely on env vars very flaky.Screenshots (if appropriate)
Types of changes
Checklist