Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-12885] Add plugin development guide for manual builds #6598

Merged
merged 14 commits into from
Nov 2, 2024

Conversation

titpetric
Copy link
Contributor

@titpetric titpetric commented Oct 1, 2024

User description

TT-12885
Summary [Plugin docs] Provide guidance on compiling plugins manually
Type Story Story
Status In Dev
Points N/A
Labels -

https://tyktech.atlassian.net/browse/TT-12885


PR Type

Documentation, Enhancement


Description

  • Added a comprehensive guide for Go plugin development, detailing environment setup, workspace creation, and plugin testing.
  • Introduced Taskfiles for automating markdown formatting and plugin development tasks, enhancing workflow efficiency.
  • Fixed indentation issues in the swagger documentation to improve readability.

Changes walkthrough 📝

Relevant files
Configuration changes
Taskfile.yml
Add Taskfile for markdown formatting with mdox                     

docs/Taskfile.yml

  • Added a Taskfile for managing markdown formatting tasks.
  • Introduced a default task to run mdox for formatting markdown files.
  • +8/-0     
    Taskfile.yml
    Add Taskfile for automating plugin development tasks         

    docs/plugins/Taskfile.yml

  • Added a Taskfile for automating plugin development tasks.
  • Defined tasks for checking out repositories, creating workspaces, and
    testing plugins.
  • +61/-0   
    Documentation
    README.md
    Add comprehensive Go plugin development guide                       

    docs/plugins/README.md

  • Added a comprehensive guide for Go plugin development.
  • Included steps for setting up the environment, creating workspaces,
    and testing plugins.
  • Provided troubleshooting tips for common issues and debugging.
  • +245/-0 
    Formatting
    swagger.md
    Fix indentation in swagger generation documentation           

    docs/swagger.md

  • Fixed indentation issues in the documentation for generating swagger
    files.
  • +2/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @buger
    Copy link
    Member

    buger commented Oct 1, 2024

    Let's make that PR title a 💯 shall we? 💪

    Your PR title and story title look slightly different. Just checking in to know if it was intentional!

    Story Title [Plugin docs] Provide guidance on compiling plugins manually
    PR Title [TT-12885] Add plugin development guide for manual builds

    Check out this guide to learn more about PR best-practices.

    Copy link
    Contributor

    github-actions bot commented Oct 1, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Documentation Clarity
    The documentation should clarify the use of specific Go versions and the necessity of matching these versions between the gateway and plugins to avoid compatibility issues. It's also recommended to provide more explicit steps or checks to ensure that developers follow these guidelines correctly.

    Error Handling
    The Taskfile commands for checking out repositories and building projects should include better error handling to ensure that any failures in these steps are caught and handled appropriately. This would prevent the continuation of the workflow in an erroneous state, which could lead to further complications.

    Copy link
    Contributor

    github-actions bot commented Oct 1, 2024

    API Changes

    no api changes detected

    Copy link
    Contributor

    github-actions bot commented Oct 1, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    docs/plugins/README.md Outdated Show resolved Hide resolved
    docs/plugins/README.md Outdated Show resolved Hide resolved
    docs/plugins/README.md Outdated Show resolved Hide resolved
    @lghiur
    Copy link
    Member

    lghiur commented Oct 2, 2024

    @titpetric I would propose to build a plugin together with the steps, like a hello world plugin, that they can copy paste from the guidance and endup with a functional plugin

    @lghiur
    Copy link
    Member

    lghiur commented Oct 2, 2024

    @titpetric I would propose to build a plugin together with the steps, like a hello world plugin, that they can copy paste from the guidance and endup with a functional plugin

    I see that it uses CustomGoPlugin in the example, which is perfect.

    Copy link
    Contributor

    @andyo-tyk andyo-tyk left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    On the assumption that all agreed changes from Tyk Docs review have been applied, I'm happy to approve.

    Copy link

    sonarcloud bot commented Nov 2, 2024

    Quality Gate Failed Quality Gate failed

    Failed conditions
    0.0% Coverage on New Code (required ≥ 80%)

    See analysis details on SonarCloud

    @titpetric titpetric merged commit 9335a51 into master Nov 2, 2024
    34 of 40 checks passed
    @titpetric titpetric deleted the docs/plugins branch November 2, 2024 07:15
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants