Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment addlink #6698

Closed
wants to merge 2 commits into from
Closed

comment addlink #6698

wants to merge 2 commits into from

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Nov 8, 2024

User description

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

PR Type

enhancement


Description

  • Commented out the AddLink method call in the spanWrapper struct within the otel_graphql_engine_detailed_test.go file. This change might be intended to temporarily disable the linking functionality for testing or debugging purposes.

Changes walkthrough 📝

Relevant files
Enhancement
otel_graphql_engine_detailed_test.go
Comment out AddLink method call in spanWrapper                     

internal/graphql/otel_graphql_engine_detailed_test.go

  • Commented out the AddLink method call within the spanWrapper struct.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @buger
    Copy link
    Member

    buger commented Nov 8, 2024

    A JIRA Issue ID is missing from your branch name, PR title and PR description! 🦄

    Your branch: test-e2e-otel

    Your PR title: comment addlink

    Your PR description:

    Description

    Related Issue

    Motivation and Context

    How This Has Been Tested

    Screenshots (if appropriate)

    Types of changes

    • Bug fix (non-breaking change which fixes an issue)
    • New feature (non-breaking change which adds functionality)
    • Breaking change (fix or feature that would cause existing functionality to change)
    • Refactoring or add test (improvements in base code or adds test coverage to functionality)

    Checklist

    • I ensured that the documentation is up to date
    • I explained why this PR updates go.mod in detail with reasoning why it's required
    • I would like a code coverage CI quality gate exception and have explained why

    If this is your first time contributing to this repository - welcome!


    Please refer to jira-lint to get started.

    Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

    Valid sample branch names:

    ‣ feature/shiny-new-feature--mojo-10'
    ‣ 'chore/changelogUpdate_mojo-123'
    ‣ 'bugfix/fix-some-strange-bug_GAL-2345'

    Copy link
    Contributor

    github-actions bot commented Nov 8, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Commented Code
    The method AddLink in the spanWrapper struct is commented out. This could be for debugging or testing, but it should be clarified or cleaned up before merging to avoid confusion and maintain clean code.

    Copy link
    Contributor

    github-actions bot commented Nov 8, 2024

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible bug
    Restore the functionality of the AddLink method by uncommenting the line

    Uncomment the line to ensure that the AddLink method properly forwards the call to
    s.span.AddLink(link), as the commented line disables the functionality.

    internal/graphql/otel_graphql_engine_detailed_test.go [447]

    -//s.span.AddLink(link)
    +s.span.AddLink(link)
    Suggestion importance[1-10]: 10

    Why: The suggestion is critical as it restores the functionality of the AddLink method, which was disabled by commenting out the essential code line. This change is crucial for maintaining the expected behavior of the method.

    10

    Copy link
    Contributor

    github-actions bot commented Nov 8, 2024

    API Changes

    no api changes detected

    @buger
    Copy link
    Member

    buger commented Nov 8, 2024

    A JIRA Issue ID is missing from your branch name, PR title and PR description! 🦄

    Your branch: test-e2e-otel

    Your PR title: comment addlink

    Your PR description: ### **User description**

    Description

    Related Issue

    Motivation and Context

    How This Has Been Tested

    Screenshots (if appropriate)

    Types of changes

    • Bug fix (non-breaking change which fixes an issue)
    • New feature (non-breaking change which adds functionality)
    • Breaking change (fix or feature that would cause existing functionality to change)
    • Refactoring or add test (improvements in base code or adds test coverage to functionality)

    Checklist

    • I ensured that the documentation is up to date
    • I explained why this PR updates go.mod in detail with reasoning why it's required
    • I would like a code coverage CI quality gate exception and have explained why

    PR Type

    enhancement


    Description

    • Commented out the AddLink method call in the spanWrapper struct within the otel_graphql_engine_detailed_test.go file. This change might be intended to temporarily disable the linking functionality for testing or debugging purposes.

    Changes walkthrough 📝

    Relevant files
    Enhancement
    otel_graphql_engine_detailed_test.go
    Comment out AddLink method call in spanWrapper                     

    internal/graphql/otel_graphql_engine_detailed_test.go

  • Commented out the AddLink method call within the spanWrapper struct.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    If this is your first time contributing to this repository - welcome!


    Please refer to jira-lint to get started.

    Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

    Valid sample branch names:

    ‣ feature/shiny-new-feature--mojo-10'
    ‣ 'chore/changelogUpdate_mojo-123'
    ‣ 'bugfix/fix-some-strange-bug_GAL-2345'

    Copy link

    sonarcloud bot commented Nov 8, 2024

    Quality Gate Failed Quality Gate failed

    Failed conditions
    0.0% Coverage on New Code (required ≥ 80%)

    See analysis details on SonarCloud

    @sredxny sredxny closed this Nov 8, 2024
    @sredxny sredxny deleted the test-e2e-otel branch November 8, 2024 13:06
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants