-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comment addlink #6698
comment addlink #6698
Conversation
A JIRA Issue ID is missing from your branch name, PR title and PR description! 🦄 Your branch: test-e2e-otel Your PR title: comment addlink Your PR description: DescriptionRelated IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
If this is your first time contributing to this repository - welcome! Please refer to jira-lint to get started. Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail. Valid sample branch names:‣ feature/shiny-new-feature--mojo-10' |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
API Changes no api changes detected |
A JIRA Issue ID is missing from your branch name, PR title and PR description! 🦄 Your branch: test-e2e-otel Your PR title: comment addlink Your PR description: ### **User description** DescriptionRelated IssueMotivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
PR Typeenhancement Description
Changes walkthrough 📝
If this is your first time contributing to this repository - welcome! Please refer to jira-lint to get started. Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail. Valid sample branch names:‣ feature/shiny-new-feature--mojo-10' |
Quality Gate failedFailed conditions |
User description
Description
Related Issue
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
PR Type
enhancement
Description
AddLink
method call in thespanWrapper
struct within theotel_graphql_engine_detailed_test.go
file. This change might be intended to temporarily disable the linking functionality for testing or debugging purposes.Changes walkthrough 📝
otel_graphql_engine_detailed_test.go
Comment out AddLink method call in spanWrapper
internal/graphql/otel_graphql_engine_detailed_test.go
AddLink
method call within thespanWrapper
struct.