Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-14041] feat: do not track API key #6858

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

antonipy
Copy link

@antonipy antonipy commented Feb 3, 2025

Description

Related Issue

#6857

Motivation and Context

As we have some keys that don't need analytics, we would like to have the option to not track specific keys.
We have keys that are either used for monitoring or some high load keys that can overwhelm our analytics database or ramp up the costs of our log aggregator.

How This Has Been Tested

I've created 2 keys:

  • 1 with DoNotTrack enabled
  • 1 with DoNotTrack disabled

The enabled key is not being tracked, while the disabled one is tracked.
Rate limiting and the quota work for both keys.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date - feat: add do_not_track parameter tyk-docs#5950
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@andyo-tyk
Copy link
Contributor

Hi @antonipy,

Thanks for this contribution. We've had this in mind for some time (just without it rising to the top of the priority list) so will definitely do a detailed review of your proposal. Please bear with me, as we need to consider potential side-effects on other components in the solution.

Thanks again for the great idea.

@andyo-tyk andyo-tyk changed the title feat: do not track API key [TT-14041] feat: do not track API key Feb 7, 2025
@antonipy
Copy link
Author

antonipy commented Feb 8, 2025

Hi @antonipy,

Thanks for this contribution. We've had this in mind for some time (just without it rising to the top of the priority list) so will definitely do a detailed review of your proposal. Please bear with me, as we need to consider potential side-effects on other components in the solution.

Thanks again for the great idea.

Hi @andyo-tyk, let me know if I can help with anything. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants