Update deck.rs #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerBloom
reviewed
May 24, 2022
| @@ -59,6 +61,10 @@ impl Deck { | |||
| self.mainboard.insert_many(card, count) | |||
| } | |||
|
|
|||
| pub fn get_card(&self, card: &AbstractCard) -> AbstractCard { | |||
There was a problem hiding this comment.
I doubt the usefulness of this method. Let's say the deck does contain the given card in the mainboard. You are getting it, cloning it, and returning it to the user. However, the returned card should contain all the same information that the given card does. Based on our conversation elsewhere, I believe you want to add methods on the AbstractCard struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a rough method to be able to get a card. But the method requires the name of the card to be passed in as an AbstractCard. Also the method returns an AbstractCard and it would be nice if it could return a string. I am not sure how to make it such that the method will simply return a card from the HashBag but this is what I could come up with