feature: odt exporter #1331
Merged
feature: odt exporter #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
areknawo
force-pushed
the
feature/odt-export
branch
from
ae02405 to
4ab6ef7
Compare
nperez0111
reviewed
Mar 3, 2025
There was a problem hiding this comment.
I'd use image-meta which is a much more lightweight lib, and is in plain JS (sharp is natively compiled I think). This would also work in both browsers & node
There was a problem hiding this comment.
Thanks. Nice to get rid of sharp.
- I've extracted the util file to @shared (as it was also used for docx)
- changed sharp to image-meta
- only import image-meta on node / vitest, as browser side it's not necessary (we use
createImageBitmap)
nperez0111
reviewed
Mar 3, 2025
|
The export looks really good. Good job here @areknawo |
nperez0111
force-pushed
the
feature/odt-export
branch
from
358c2bc to
4c57877
Compare
YousefED
force-pushed
the
feature/odt-export
branch
from
19ef51b to
358c2bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an ODT exporter, with support for a customizable header & footer.