Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: parallelize across browsers #1472

Merged
merged 10 commits into from
Mar 4, 2025
Merged

build: parallelize across browsers #1472

merged 10 commits into from
Mar 4, 2025
+71 −18

Conversation

nperez0111
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Feb 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 4, 2025 1:11pm
blocknote-website ❌ Failed (Inspect) Mar 4, 2025 1:11pm

YousefED
YousefED reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Looks good to me :) What's the part that runs the test in docker?

Note that I don't have any opinion on nx vs. x. vs. y (except that lerna is deprecated and we should get rid of it). I'd not invest too much further in nx unless you're confident it's a solid choice going forward compared to other solutions

@nperez0111
Copy link
Contributor Author

Cool! Looks good to me :) What's the part that runs the test in docker?

We already merged that onto main last week: https://github.com/TypeCellOS/BlockNote/blob/main/.github/workflows/build.yml#L57

Note that I don't have any opinion on nx vs. x. vs. y (except that lerna is deprecated and we should get rid of it). I'd not invest too much further in nx unless you're confident it's a solid choice going forward compared to other solutions

I've used NX and turborepo before, I think NX is better but, I agree that we should leave it alone for now and make a decision on it later. For now, was a very easy integration to just enable it and keep everything run with lerna

@nperez0111 nperez0111 merged commit 0f18cba into main Mar 4, 2025
1 of 6 checks passed
@nperez0111 nperez0111 deleted the parallelize branch March 4, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YousefED YousefED YousefED left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nperez0111 @YousefED