Refactor code parser to ast from regex #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex parsing engine was not handling compiled code correctly, it would extract malformed tokens when self invoked functions and compiled imported modules were introduced in the code (
(0, imported)(arg)
).I used babel's parser to parse the code string and traversed the AST to extract functions and method names.
Several other changes had to be made, since the Regex parser did not rely on valid code, it could handle parts of complete code to extract information.
This is no longer valid, so I had to change the way ObjectPropertyCodeRetriever works:
It used to get object and property, and extract the code for that property. Since the only usage was when iterating over an object's fields, and only the functions were necessary, I changed it to return a functional mock class with all the required properties.
I changed the tests to match this scenario.