Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jiraLinked): remove the check #182

Merged
merged 1 commit into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-and-release-beta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Test skipping checks
uses: ./
with:
skipChecks: 'jira-linked,secrets-scan'
skipChecks: 'secrets-scan'
githubToken: ${{ secrets.GITHUB_TOKEN }}
dockerUsername: ${{ secrets.GITLEAKS_DOCKER_USERNAME }}
dockerPassword: ${{ secrets.GITLEAKS_DOCKER_PASSWORD }}
Expand Down
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ easier time rolling out new checks to teams. Win-win!

## Included Checks

- `jira-linked`: never forget a Jira Issue key in your commits or PRs
again!
- `secrets-scan`: make sure you're never ever ever commiting a secret to
your repo. _Shhh, it's a secret_ :shushing_face:
- `pii-detection`: make sure you're not uploading files with Personal Identifiable
Expand Down Expand Up @@ -40,7 +38,7 @@ commas:
```yaml
---
with:
skipChecks: 'jira-linked,secret-scan'
skipChecks: 'secret-scan,required-typescript'
```

Refer to the [list of checks](#included-checks) for the proper names
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ inputs:
description: 'Optional checks to enable'
githubToken:
required: true
description: 'The github token to get PR info when checking for Jira Issue key'
description: 'Required for checks that need access to Github'
runs:
using: 'node20'
main: 'dist/index.js'
131 changes: 0 additions & 131 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

Loading
Loading