Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace _() with wxGetTranslation() for non-literal strings #279

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

0tkl
Copy link
Contributor

@0tkl 0tkl commented Jan 13, 2025

Building Aegisub against wxWidgets trunk (or 3.3.0) has been failing since wxWidgets/wxWidgets@3dddaeb . The updated doc said:

the _() macro is defined to do nearly the same thing as wxGetTranslation(), with the exception that the argument to _() must be a string literal.

Speaking of 2417c1f. Before applying the fix, the COMMAND_GROUP macro will expanded like this :
screenshot

@arch1t3cht
Copy link
Member

The _ around the parameters to COMMAND_GROUP is probably there so that xgettext can detect the strings as translatable strings. To work around that, COMMAND_GROUP could be added to the lists of keywords in make_pot.sh

@0tkl 0tkl marked this pull request as draft January 14, 2025 09:41
@0tkl 0tkl marked this pull request as ready for review January 24, 2025 06:12
@arch1t3cht arch1t3cht merged commit 207a1f4 into TypesettingTools:master Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants