Skip to content

Commit

Permalink
Merge pull request kitodo#5954 from matthias-ronge/patch-89
Browse files Browse the repository at this point in the history
Fix potential input resource leak
  • Loading branch information
solth authored Apr 11, 2024
2 parents 2c9a15c + 3203e66 commit 1e6d5a0
Showing 1 changed file with 1 addition and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,14 @@
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.net.URI;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
import java.util.stream.Stream;

import org.apache.logging.log4j.LogManager;
Expand Down Expand Up @@ -232,10 +228,7 @@ public static void updateIdentifier(int processId) throws DAOException, IOExcept
Process process = ServiceManager.getProcessService().getById(processId);
URI metadataFileUri = ServiceManager.getFileService().getMetadataFilePath(process);
try (InputStream fileContent = ServiceManager.getFileService().readMetadataFile(process)) {
InputStreamReader inputStreamReader = new InputStreamReader(fileContent);
BufferedReader bufferedReader = new BufferedReader(inputStreamReader);
List<String> textLines = bufferedReader.lines().collect(Collectors.toList());
String textContent = String.join("", textLines);
String textContent = new String(fileContent.readAllBytes());
textContent = textContent.replace(ID_PLACEHOLDER, String.valueOf(processId));
try (OutputStream updatedFileContent = ServiceManager.getFileService().write(metadataFileUri)) {
updatedFileContent.write(textContent.getBytes());
Expand Down

0 comments on commit 1e6d5a0

Please sign in to comment.