-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let the Scale-up of HIV, TB, Malaria services go to "MAXIMAL" levels (as well as target levels) #1441
Conversation
update ResourceFile_HIV.xlsx, ResourceFile_malaria.xlsx, ResourceFile_TB.xlsx to include max scale-up
…ot supported. Only unambiguous timedelta values durations are supported. Allowed units are 'W', 'D', 'h', 'm', 's', 'ms', 'us', 'ns'
…ers_for_program_scaleup not within read_parameters as this is read before the analysis script updates parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tara -- looks like it will do the job nicely!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes from lifestyle coming in again!? Very weird! I'll have to roll back for the version to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it won't run locally with np.timedelta64 value="M" for me:
enhanced_lifestly.py np.timedelta64 as ValueError: Unit M is not supported. Only unambiguous timedelta values durations are supported. Allowed units are 'W', 'D', 'h', 'm', 's', 'ms', 'us', 'ns'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very weird. Matt/Asif would know better but I guess it's to do with perhaps your setup not being quite the same the specification? (In which case delete it and start again with the conda environment setup...?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no...
src/scripts/comparison_of_horizontal_and_vertical_programs/analysis_maxHTM_scenario.py
Show resolved
Hide resolved
update scenarios with 'type_of_scaleup': 'max',
…l' into tara_max_HTMscenarios_setup_29Jul
closing in favour of #1443 (final commit accidentally brought in some unwanted changes that couldn't easily be reverted). |
This PR partly addresses issue #1411 where programme scale-up should be 'target' or 'max'
The parameter for choosing programme scale-up has changed to 'type_of_scaleup' and requires a string, default value is 'none'
in def update_parameters_for_program_scaleup, the values for scale-up parameters are chosen based on this parameter
test_htm_scaleup is also updated
script: comparison_of_vertical_programs/analysis_maxHTM_scenario.py runs scenarios with program scale-up. This only changes scale-up in hiv, tb and malaria and uses the default values for all other modules.