Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIV diagnosis for people in primary infection and general population #187

Merged
merged 29 commits into from
Jul 24, 2024

Conversation

pineapple-cat
Copy link
Collaborator

Addresses #112 and #181.

@pineapple-cat pineapple-cat changed the title HIV Diagnosis HIV diagnosis for people in primary infection and general population Jun 3, 2024
src/hivpy/prep.py Outdated Show resolved Hide resolved
src/hivpy/hiv_status.py Outdated Show resolved Hide resolved
src/hivpy/hiv_status.py Outdated Show resolved Hide resolved
@pineapple-cat pineapple-cat marked this pull request as ready for review June 21, 2024 19:16
@pineapple-cat pineapple-cat requested a review from mmcleod89 June 27, 2024 13:32
src/hivpy/hiv_status.py Outdated Show resolved Hide resolved
src/hivpy/hiv_status.py Outdated Show resolved Hide resolved
@mmcleod89
Copy link
Collaborator

Let's also move Diagnosis into its own module

Copy link
Collaborator

@mmcleod89 mmcleod89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two things:

  • We should probably include more variation in test general loss at diagnosis for some variables that aren't checked like num stp
  • The variable for HIV infection > 6months isn't set anywhere. We could set it here using the hiv infection date if it's not going to be used anywhere else?

@pineapple-cat
Copy link
Collaborator Author

All comments addressed; I just need to add a module overview and data variable section to the tutorial and this will be ready to merge.

@pineapple-cat pineapple-cat requested a review from mmcleod89 July 12, 2024 16:14
Copy link
Collaborator

@mmcleod89 mmcleod89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine; failing tests are not related to this PR and I will upload a fix today!

@mmcleod89 mmcleod89 merged commit c35f462 into development Jul 24, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Probability of loss at diagnosis to be implemented with diagnosis code HIV diagnosis from testing
3 participants