-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIV diagnosis for people in primary infection and general population #187
Conversation
…neral population loss of care at diagnosis.
… update to loss of care after general diagnosis.
Let's also move Diagnosis into its own module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two things:
- We should probably include more variation in test general loss at diagnosis for some variables that aren't checked like num stp
- The variable for HIV infection > 6months isn't set anywhere. We could set it here using the hiv infection date if it's not going to be used anywhere else?
All comments addressed; I just need to add a module overview and data variable section to the tutorial and this will be ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine; failing tests are not related to this PR and I will upload a fix today!
Addresses #112 and #181.