Rename to 'Quorum of rejection' (#4677)

UMAprotocol · Apr 15, 2024 · cb5ca02 · cb5ca02
1 parent f8e8513
commit cb5ca02
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/src/components/ProposalsItemFooter.vue b/src/components/ProposalsItemFooter.vue
@@ -12,17 +12,17 @@ const quorumText = computed(() => {
     return '';
   }
 
-  const optimisticQuorum = props.proposal.quorumType === 'optimistic';
+  const quorumOfRejection = props.proposal.quorumType === 'rejection';
   const percentage = formatPercentNumber(
-    optimisticQuorum
+    quorumOfRejection
       ? Number(
           props.proposal.scores
             .filter((c, i) => i === 1)
             .reduce((a, b) => a + b, 0) / props.proposal.quorum
         )
       : Number(props.proposal.scores_total / props.proposal.quorum)
   );
-  return optimisticQuorum
+  return quorumOfRejection
     ? `${percentage} quorum rejection`
     : `${percentage} quorum reached`;
 });

diff --git a/src/components/SettingsVotingBlock.vue b/src/components/SettingsVotingBlock.vue
@@ -40,8 +40,8 @@ const { form, validationErrors } = useFormSpaceSettings(props.context);
               name: 'Default'
             },
             {
-              value: 'optimistic',
-              name: 'Optimistic'
+              value: 'rejection',
+              name: 'Quorum of rejection'
             }
           ]"
           :disabled="isViewOnly"

diff --git a/src/components/SpaceProposalResultsQuorum.vue b/src/components/SpaceProposalResultsQuorum.vue
@@ -17,7 +17,7 @@ const { formatCompactNumber, formatPercentNumber } = useIntl();
   <div class="pt-2 text-skin-link">
     <div class="flex justify-between">
       <div class="flex items-center gap-1">
-        {{ quorumType === 'optimistic' ? 'Optimistic Quorum' : 'Quorum' }}
+        {{ quorumType === 'rejection' ? 'Quorum of rejection' : 'Quorum' }}
       </div>
       <LoadingSpinner v-if="loadingQuorum" class="mr-1" />
       <div v-else class="flex gap-2">
@@ -29,7 +29,7 @@ const { formatCompactNumber, formatPercentNumber } = useIntl();
         />
         <i-ho-x
           v-if="
-            quorum && quorumType === 'optimistic' && totalQuorumScore >= quorum
+            quorum && quorumType === 'rejection' && totalQuorumScore >= quorum
           "
           class="text-red"
         />

diff --git a/src/composables/useQuorum.ts b/src/composables/useQuorum.ts
@@ -18,7 +18,7 @@ export function useQuorum(props: QuorumProps) {
   const quorumType = ref('default');
 
   const totalQuorumScore = computed(() => {
-    if (props.proposal.quorumType === 'optimistic') {
+    if (props.proposal.quorumType === 'rejection') {
       return props.results.scores
         .filter((c, i) => i === 1)
         .reduce((a, b) => a + b, 0);

diff --git a/src/helpers/interfaces.ts b/src/helpers/interfaces.ts
@@ -179,7 +179,7 @@ export interface ExtendedSpace {
     hideAbstain: boolean;
     period: number | null;
     quorum: number | null;
-    quorumType: 'default' | 'optimistic';
+    quorumType: 'default' | 'rejection';
     type: string | null;
     privacy: string | null;
   };
@@ -230,7 +230,7 @@ export interface Proposal {
   validation: VoteValidation;
   discussion: string;
   quorum: number;
-  quorumType: 'default' | 'optimistic';
+  quorumType: 'default' | 'rejection';
   scores: number[];
   scores_state: string;
   scores_total: number;