feat: show warning if gas exceeds 500_000, refactor state #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Reinis-FRP can you verify that this gas amount returned from sim is the same gas the bot uses to threshold automatic execution |
gsteenkamp89
commented
Jan 31, 2024
Comment on lines
183
to
198
| <div | ||
| class="flex flex-col w-full items-start text-left" | ||
| v-if="simulationState.exceedsGasSubsidy" | ||
| > | ||
| <p class="text-sm"> | ||
| <strong class="text-skins text-base text-red">Warning:</strong> | ||
| This transaction will | ||
| <strong class="underline" | ||
| >not be automatically executed by oSnap.</strong | ||
| > | ||
| This transaction used | ||
| {{ simulationState.gasUsed.toLocaleString() }} gas, which exceeds | ||
| oSnap's maximum subsidized amount of | ||
| {{ OSNAP_GAS_SUBSIDY.toLocaleString() }}. | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
just removed the unnecessary div that wraps this text
gsteenkamp89
commented
Jan 31, 2024
| </div> | ||
|
|
||
| <TuneButton | ||
| class="group text-sm md:text-[18px] hover:cursor-pointer justify-center w-full flex gap-2 mx-auto items-center" | ||
| :tooltip="'Reset Simulation'" | ||
| @click="resetState" | ||
| > | ||
| Reset | ||
| Reset Simulation |
gsteenkamp89
commented
Jan 31, 2024
| @@ -163,39 +163,37 @@ async function simulate() { | |||
| > | |||
| </div> | |||
| <a | |||
| v-if="simulationState.simulationLink.public" | |||
There was a problem hiding this comment.
if link isn't public, don't share it
yes, 500K is default value used by execution bot |
Reinis-FRP
reviewed
Feb 1, 2024
| @@ -53,3 +56,7 @@ export function prepareTenderlySimulationPayload(props: { | |||
|
|
|||
| return { safe: payload }; | |||
| } | |||
|
|
|||
| export function exceedsOsnapGasSubsidy(res: TenderlySimulationResult): boolean { | |||
| return res.gasUsed > OSNAP_GAS_SUBSIDY; | |||
There was a problem hiding this comment.
Note that simulation gas usage might be lower than real one due to how state overrides short-circuit the OOv3 settlement logic. The execution bot uses ethers estimateGas on oSnap executeProposal call at the time when challenge window passed, so it might be worth checking this divergence in some test runs
There was a problem hiding this comment.
interesting we might want to implement some sort or buffer percentage.
gsteenkamp89
merged commit d5fc559
into
gerhard/uma-2153-ui-render-the-tenderly-simulation-button-in-the-tx-builder
4 checks passed
gsteenkamp89
deleted the
gerhard/uma-2168-add-snapshot-ui-warning-to-gas-limit-when-user-creating
branch
daywiss
pushed a commit
that referenced
this pull request
Feb 1, 2024
gsteenkamp89
added a commit
that referenced
this pull request
Feb 13, 2024
daywiss
pushed a commit
that referenced
this pull request
Feb 19, 2024
gsteenkamp89
added a commit
that referenced
this pull request
Feb 21, 2024
daywiss
added a commit
that referenced
this pull request
Feb 22, 2024
* create base component logic * update styling * validate payload, handle request and update styles * better mobile styles * use separate reset button * feat: show warning if gas exceeds 500_000, refactor state (#121) * feat: add simulation in proposal view (#122) * feat: fetch implementation abi in transaction builder for proxy contracts (#124) * use isValid flag to check transactions in simulation * better feedback for EOA in "to" field & ABI with no write functions * clean up * reset parameters if ABI changes * revert extra green & red variables * fix typo * use better icon convention --------- Co-authored-by: Gerhard Steenkamp <[email protected]> Co-authored-by: Gerhard Steenkamp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes UMA-2168
closes UMA-2336
motivation
oSnap will only subsidize 500_000 gas and execute transaction automatically. We want to show users a warning if their transaction is exceeding this limit.
screenshots