-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8주차/모리] 워크북 제출합니다. #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨Feat Join Member
🐛 [fix] Member and MemberAddress N:M relationship to 1:1
✨ [Feat] Add an API to add stores to a specific area
📝 [docs] Add documentation for @ExistCategories annotation
✨ [Feat] Add API to add review to store
📝 [docs] Add documentation for @ExistStore annotation
✨ [Feat] Add API to add missions to stores
✨ [Feat] Challenge mission
qmean
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 모리!
머지해주시면 됩니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 실습 체크리스트
✅ 컨벤션 체크리스트
📌 주안점
이슈를 통해 브랜치를 생성하고 문제를 해결했습니다.
궁금한 점이 있는데, 커밋을 할때 커밋 컨벤션에 맞게 mission: ~ 이런 식으로 하는게 맞는지, 아니면 [feat] add api ~ 이런 식으로 커밋 메세지를 해야 되는지 질문드립니다!
이번주도 코드 리뷰해주셔서 미리 감사드립니다 :)