Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPC-10057: Adjust Code to Treat HRP and HNRP Plan Types Equivalently … #1333

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

HPC-10057: Adjust Code to Treat HRP and HNRP Plan Types Equivalently … #1333

wants to merge 1 commit into from

Conversation

aessid
Copy link
Contributor

@aessid aessid commented Feb 21, 2025

…in HA.

berliner
berliner reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@berliner berliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add the summary of the grouped order of plan types to Drupal\ghi_blocks\Traits\GlobalSettingsTrait::getCheckboxOptions(), same as you did for FTS

html/modules/custom/ghi_blocks/src/Traits/GlobalSettingsTrait.php Outdated
Comment on lines 81 to 90
$plan_types = TaxonomyHelper::loadMultipleTermsByVocabulary('plan_type');
array_walk($plan_types, function ($term) use (&$grouped_plans_types) {
if ($term->field_group_key->value) {
$grouped_plans_types[$term->field_group_key->value][$term->tid->value] = $term->name->value;
}
else {
$grouped_plans_types[$term->tid->value] = $term->name->value;
}
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this code to Drupal\ghi_plans\Traits\PlanTypeTrait.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2025 •
edited
Loading

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.3.17 (cli) (built: Feb 15 2025 01:07:58) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.17, Copyright (c) Zend Technologies with Zend OPcache v8.3.17, Copyright (c), by Zend Technologies with Xdebug v3.4.1, Copyright (c) 2002-2025, by Derick Rethans Composer version 2.8.6 2025-02-25 13:03:50
Drupal Logs

Pusher: @aessid, Action: pull_request, Workflow: Run tests

@aessid aessid force-pushed the aessid/HPC-10057 branch 2 times, most recently from 7fc2cf2 to 93d8d85 Compare February 26, 2025 17:02
@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage
Statements: 22.32% ( 3353 / 15024 )
Methods: 24.34% ( 358 / 1471 )
Lines: 22.1% ( 2995 / 13553 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berliner berliner berliner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aessid @berliner