Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventional changelog #538

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conventional changelog #538

wants to merge 9 commits into from

Conversation

attiks
Copy link
Contributor

@attiks attiks commented Oct 22, 2021

No description provided.

@attiks
Copy link
Contributor Author

attiks commented Oct 22, 2021

Reviewers added to get feedback, tool can be found at https://github.com/marcocesarato/php-conventional-changelog

Copy link
Contributor

@rupl rupl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm assuming from the name that these would be the guidelines to follow: https://www.conventionalcommits.org/en/v1.0.0/#summary

Should we add a note to the README somewhere (or maybe in the project template for all new projects)

@attiks
Copy link
Contributor Author

attiks commented Oct 22, 2021

Should we add a note to the README somewhere (or maybe in the project template for all new projects)

Yes, should be part of https://github.com/UN-OCHA/drupal-starterkit

Copy link
Contributor

@lazysoundsystem lazysoundsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a useful tool - it would be good to use it for a while in this repo and perhaps a couple of others to assess whether we want to adopt it for all the others too.

Copy link
Contributor

@left23 left23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@attiks A note on how this is intended to be use for the IASC project would be helpful.

@attiks
Copy link
Contributor Author

attiks commented Oct 25, 2021

Waiting for 1 open PR, marcocesarato/php-conventional-changelog#26 it now changes both composer and package json with the version number, which feels redundant.

Will add proper docs once this gets committed, for now you can have a look at https://github.com/marcocesarato/php-conventional-changelog/blob/main/docs/config.md#default-settings

Will still need to test if reference to issue can be in a single line commit or not. But idea is to mark new features with prefix feat: followed by commit message and (for now) reference to issues on the next line

@left23
Copy link
Contributor

left23 commented Mar 3, 2022

@attiks When you have a chance can you take a look - I attempted to merge develop into this branch and run composer update marcocesarato/php-conventional-changelog but I get the same error locally as I do in the failed build Could not scan for classes inside "scripts/composer/ScriptHandler.php" which does not appear to be a file nor a folder

It might have to do with https://github.com/UN-OCHA/iasc8/pull/538/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R138-R142 ?

cc @lazysoundsystem In case you've come across this

@lazysoundsystem
Copy link
Contributor

@left23 a month or so after this branch, the ScriptHandler script was removed in https://github.com/UN-OCHA/iasc8/pull/543/files - I'll push a change with that section removed here.

@left23
Copy link
Contributor

left23 commented Mar 30, 2022

@attiks Is this ready to be merged so we can use it?

@orakili orakili removed their request for review July 19, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants