Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RW-1176] Fix type error in job importer validate city #1019

Merged
merged 2 commits into from
Feb 17, 2025
Merged

[RW-1176] Fix type error in job importer validate city #1019

merged 2 commits into from
Feb 17, 2025

Conversation

orakili
Copy link
Collaborator

@orakili orakili commented Feb 14, 2025

Refs: RW-1176

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions Docker version 26.1.3, build b72abbb PHP 8.3.17 (cli) (built: Feb 15 2025 01:07:58) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.17, Copyright (c) Zend Technologies with Zend OPcache v8.3.17, Copyright (c), by Zend Technologies with Xdebug v3.4.1, Copyright (c) 2002-2025, by Derick Rethans Composer version 2.8.5 2025-01-21 15:23:40
Drupal Logs
PHP Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage
Statements: 24.15% ( 3515 / 14553 )
Methods: 25.72% ( 222 / 863 )
Lines: 24.05% ( 3293 / 13690 )

@orakili orakili requested a review from cafuego February 17, 2025 02:12
cafuego
cafuego approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@cafuego cafuego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that'll do it.

@orakili orakili merged commit 985aa33 into develop Feb 17, 2025
2 checks passed
@lazysoundsystem lazysoundsystem deleted the RW-1176 branch February 18, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafuego cafuego cafuego approved these changes

@lazysoundsystem lazysoundsystem Awaiting requested review from lazysoundsystem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orakili @cafuego