Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add mail modules #421

Merged
merged 3 commits into from
Jan 23, 2024
Merged

chore: add mail modules #421

merged 3 commits into from
Jan 23, 2024

Conversation

lazysoundsystem
Copy link
Contributor

Refs: OPS-9523

Copy link

github-actions bot commented Jan 3, 2024

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.14 (cli) (built: Dec 21 2023 20:19:50) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.14, Copyright (c) Zend Technologies with Zend OPcache v8.2.14, Copyright (c), by Zend Technologies with Xdebug v3.3.0, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.6 2023-12-08 18:32:26
Drupal Logs

Pusher: @cafuego, Action: pull_request, Workflow: Run tests

@cafuego cafuego force-pushed the OPS-9523-add-mail-modules branch from 7de1d8e to 9560794 Compare January 18, 2024 23:08
Copy link

Coverage Report

Totals Coverage

@lazysoundsystem
Copy link
Contributor Author

@cafuego - as per original instructions, I'm not planning to merge any of these (i.e. OPS-9523-add-mail-modules branches for any of the repos) - do say if that would be helpful, otherwise I'll leave it to you when you're ready..

@cafuego
Copy link
Contributor

cafuego commented Jan 23, 2024

@lazysoundsystem They should all be safe to merge as they are; that will prevent the need to fix merge conflicts after the next security update so you may as well.

My plan is to apply the proposed config for using msmtp on dev and SES on prod to GMS, then update core.extensions.yml to enable the modules, then apply it to other properties. And then NEVER EVER ROTATE AWS CREDENTIALS AGAIN :-)

@cafuego cafuego merged commit 4d183ac into develop Jan 23, 2024
1 check passed
@lazysoundsystem lazysoundsystem deleted the OPS-9523-add-mail-modules branch January 23, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants