Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNO-817 Resources layout #430

Merged
merged 6 commits into from
Jan 30, 2024
Merged

UNO-817 Resources layout #430

merged 6 commits into from
Jan 30, 2024

Conversation

left23
Copy link
Contributor

@left23 left23 commented Jan 16, 2024 •
edited
Loading

  1. Creates Resources view mode for Reliefweb River paragraph type drush cim
  2. Styles for .paragraph--type--reliefweb-river.paragraph--view-mode--resources to share cards styles, and lay out in 3 columns, on a grey background
  3. Moves rule for layout--twocol-sidebar relating to Layout Paragraphs from uno-river.css to uno-layout.css

See UNO-817 for screenshots

@github-actions GitHub Actions
Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.14 (cli) (built: Dec 21 2023 20:19:50) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.14, Copyright (c) Zend Technologies with Zend OPcache v8.2.14, Copyright (c), by Zend Technologies with Xdebug v3.3.0, Copyright (c) 2002-2023, by Derick Rethans Composer version 2.6.6 2023-12-08 18:32:26
Drupal Logs

Pusher: @left23, Action: pull_request, Workflow: Run tests

@left23 left23 self-assigned this Jan 16, 2024
@left23 left23 marked this pull request as draft January 16, 2024 14:45
@left23 left23 marked this pull request as ready for review January 23, 2024 08:58
@left23 left23 requested a review from orakili January 23, 2024 08:59
orakili
orakili approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@orakili orakili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Please check #433 for some options to help style the reliefweb river paragraphs in the form.

Merge pull request #433 from UN-OCHA/UNO-817-view-mode
161b185 
[UNO-817] Paragraph view mode theme suggestion
@github-actions GitHub Actions
Copy link

Coverage Report

Totals Coverage

@left23 left23 added the blocked Do not merge this label Jan 25, 2024
@left23 left23 merged commit 597e1ad into develop Jan 30, 2024
2 checks passed
@left23 left23 deleted the UNO-817 branch January 30, 2024 15:29
@left23 left23 removed the blocked Do not merge this label Feb 1, 2024
@left23 left23 mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orakili orakili orakili approved these changes

Assignees

@left23 left23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@left23 @orakili