Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Brining Release up to 2023 Q2 Status (#18)
* Added the parameter field for the SUMMARY DBS keyword to the keyword window * Small typo fix in the databaseDescription.xlsx file * Bug fix: Grey screen was occurring when trying to edit the PLANT/NATURAL management action window. * Removed two extraneous unused variables, and another unused commented-out section, from the kcpVetting function. * Limited the types of file extensions the kcpUpload button looks for to be .kcp and .RData * • Bug fix: when trying to change to freeform with a stand or group selected, the grey screen was occurring. Added a clause to instead return from the function in this instance, similar to how the Edit button works (i.e., nothing happens). • Bug fix: when clicking the “Save in component collection” button more than once when the last keyword in the KCP was in a conditional block, and ENDIF keyword was being added more than once. • Added a few “## “ labels above some observer functions that did not have them, making identification easier. * Removed all references to "fvsOLdev", added code that tests on the library fvsOL is loaded from and if it is R-dev, then the neading is adjusted to say "Dev". Modified the run scripts so that rFVS will be loaded from R-dev if it is located at that location. * Modified the date of revision, cleaned up some line endings, reorganized a bit of code so that a cluster instance is not started if an error condition is discovered. * Removed one more "devVersion" code sequence, cleaning up the fvsOLdev issue. * Fixed a small bug when the PlotInit table is absent in the mapping code. * Updates to voleqnum.kwd to include additional available volume equations * modifications to basekeys.kwd to allow for user input to top diameter limits and stump in BFVOLUME and VOLUME keyword dialogs * Minor typo fix in ui.R * Added the three cmpSummary tables to the list of simulation-level tables for use in the "Database tables to consider" window in the View outputs > Load menu. * Standardized the "## " titles for observer functions in server.R as many were absent, or had different number of pound signs and spacing. This is to (hopefully) make easier the searching for, and learning of, code for any future interface programmers. * Updated the "Release date" variables to be 20230106 * Added the old iet01.key and iet01.tre files into a ../tests folder for use with the introductory rFVS wiki examples. * Deletion of fvsOLdev folder from the development branch * Typo fix * Bug fix: composite tables were showing up in the "Database tables to consider" window when a single run with a single stand was selected in the "Runs to consider" window. * Updated Wensel &Olsen Scribner 32 function names to remove a '-' that was causing an uncommon character. Replaced with parentheses. * Voleqnum.kwd parm updates Added space to Wensel & Olsen Removed all Sharpneck equations from availability Removed F0#FW2W260, general hemlock equations Compared volume eq table document returns (BF vol vs cubic vol) and removed equations that didn't return the proper volume type from the respective cubic ft vs board ft equation lists * Added some more standardization for labeling functions, and removed an unnecessary clause that was precluding the creation of the stand and stock table that was introduced in a recent test commit. * Added 3 eqs missing from ec, wc, bm, pn, op, oc 628BEHW093 = Region 6:Engelmann spruce - Behres Hyperbola 616TRFW747 = Region 6:black cottonwood - PNW tariff Equation 616TRFW998 = Region 6:unknown hardwood - PNW tariff Equation * Strange character encoding correction Found other instances of 'Behre's' begin translated with unusual characters. Changed to 'Behres' * Removal of newSum variable from server.R and calls to the writeKeyFile function that was preventing new runs from keeping the Summary2 table as the default if any previous runs had the Summary table in them. * Bringing Main up to 2023 Q2 Status (#17) * rFVS: added fvsCutNow and fvsMakeyFile functions, Fixed a typo in fvsAddActivity, added the ability to set/get "special" tree tag and kutkod used in prescription thinnings. fvsOL: modified code to support package sf (more work to do on this). * Started process of adding support of package sf * Rmeoved "NAMESPACE" from management by the repository * Finished changes to convert from package sp to sf for spatial data * Commented out the ability to specify "development" code in new projects. * Fixed a bug I just introduced. * Removed the use of R-dev as an installation library (a change to the makefiles) This restores the code to a previous version. * rFVS: Improved the documentation for fvs[Get|Set]SpeciesAttrs, reset the revision date in DESCRIPRTION * fvsOL: Fixed a bug that caused a warning in some cases when a run's variant was not set, modified the code that runs the Acadian variant so that fvs tree ids are maintained (the trees were being renumbered). Updated the revision tag in DESCRIPTION * Pull Request #14 Updates from NCrookston * 1. When trying to manually add the RRTREIN and BBCLEAR root disease keywords a crash was occurring. 2. When trying to add in the THINRDSL keyword into the Run contents using a non-NE variant, a crash was occurring (keyword only applies to the NE variant). 3. When trying to import a custom SQL query using the Import runs and other items, a crash was occurring, and the query was also not showing up in the Custom query menu after import. 4. Improvements to the SQLIN/SQLOUT database keyword windows: a. Updated example text & code was added to below the windows b. A column ruler was added to be above the editor window c. The needed DATABASE/END keywords are now automatically added around the query when building the keyword file at run time (they were previously being tagged as “base” instead of “dbs”) 5. The “Rebuild StdStk” button now works in that if a run containing a StdStk (or cmpStdStk) table is pre-selected in the “Runs to consider” window, and then the “Rebuild StdStk” button is clicked after changing the “DBH class size” and/or “Large DBH” values, the “DBHClasses” under the Explore menu are immediately updated. Previously, a run had to not be selected before changing either of those values, and then a run selected, for the changes to then reflect under the Explore menu. 6. A logical variables was added to the keyword writing function to prevent two successive END keywords from being written that was happening when a base keyword was following a conditionally-scheduled non-base keyword. * Update fvsRunUtilities.R Fixing inadvertent overwrite when merging multiple pull requests * Bug fixes (fvsOL): • When trying to import a project backup the check for a blank/null INV_YEAR field in the input database was causing a crash if the column name for that variables was not upper case. The tolower() function was added to coerce it to lower case for even comparison of all casings of that variable. • The keyword writing code was missing logic to handle when a conditional was following a previous conditional that had multiple non-base keywords. • When deleting the only stand from a run that had components attached to groups (thus creating a blank-appearing run), the components were being inherited by any subsequently-added stands. This made sense for runs with multiple stands (where deleting one stand didn’t result in a blank run) but was deemed confusing (since adding stands into a blank run should not carry any keyword inheritance). Now, any groups & their associated keywords associated with the stand being deleted from a single-stand run are now removed from the run upon clicking “Cut/delete”. • The sumOnSpecies indicator variable in the graphing code was not setup to accommodate the 3 newer species codes (SpeciesFVS, SpeciesPLANTS, SpeciesFIA) resulting in plots containing any one of those 3 variables were resulting in erroneously large Y-axis values (e.g., 4000ft tall trees). * 2023 q2 shettles final (#17) * Bug fixes (fvsOL): • When trying to import a project backup the check for a blank/null INV_YEAR field in the input database was causing a crash if the column name for that variables was not upper case. The tolower() function was added to coerce it to lower case for even comparison of all casings of that variable. • The keyword writing code was missing logic to handle when a conditional was following a previous conditional that had multiple non-base keywords. • When deleting the only stand from a run that had components attached to groups (thus creating a blank-appearing run), the components were being inherited by any subsequently-added stands. This made sense for runs with multiple stands (where deleting one stand didn’t result in a blank run) but was deemed confusing (since adding stands into a blank run should not carry any keyword inheritance). Now, any groups & their associated keywords associated with the stand being deleted from a single-stand run are now removed from the run upon clicking “Cut/delete”. • The sumOnSpecies indicator variable in the graphing code was not setup to accommodate the 3 newer species codes (SpeciesFVS, SpeciesPLANTS, SpeciesFIA) resulting in plots containing any one of those 3 variables were resulting in erroneously large Y-axis values (e.g., 4000ft tall trees). * The BurnReDB database keyword was still being displayed as BurnRept in the Keywords menu dropdown menu list. * Removal of a browser() command from code. * 1) Added keyword windows for the REGREPTS and INVSTATS DBS keywords (#18) 2) Added the new BHTWTBA and AHTWTBA Event Monitor variables to the "Variables" dropdown list * Update of "Release date" for upper right panel in GUI to read 20230518 for upcoming Q2 release. (#19) * Modified R/externalCallable.R to add the ability to delete stands and modified the function that lists stands to return a data.frame that has the stand uuid as well as the standid. Modified fvsRunAadian to not use fvsStopPoint 7. The stoppoint works, but what we were trying to accomplish was not getting done. * Removed NAMESPACE from being tracked by git. It is automatically built when R builds the package. * 1) Updated the example text under the SQLout window (#21) 2) Fixed the Lory's height EM variable calculation so that it inserts the correct variable --------- Co-authored-by: Nicholas Crookston <[email protected]> Co-authored-by: MICHAEL A. SHETTLES <[email protected]> --------- Co-authored-by: Michael Shettles <[email protected]> Co-authored-by: Nicholas Crookston <[email protected]> Co-authored-by: mshettles <[email protected]>
- Loading branch information
4 people
authored
May 22, 2023
1 parent
a498fd3
commit 122d057