-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions deployment #1
Conversation
Awesome, thanks @i-baumann! I might ask @matthewfeickert to review and test at some point since he does a lot of this. |
Once this is merged we'll probably need to render locally once with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on the R stuff, but I would suggest using a GitHub Actions based deployment over branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge in these suggested changes and then if things are passing I'll do another review and squash and merge the PR in the morning (Europe time).
Thanks for this PR @i-baumann!
@cranmer I've gone ahead and tested the deployment on my fork with the state of this PR and it works as expected. Here's my fork's website that got deployed via GitHub Actions: https://matthewfeickert.github.io/open_source_survey_results/ This all LGTM, so if you agree I'll write a summary commit message and get this merged, unless you would prefer for there to not be any more deployments until next week (I think this should be fine to just deploy, given that it works). |
@matthewfeickert thanks a ton for looking at this! Could you also update the readme to reflect your changes? |
48b2722
to
2b726cb
Compare
* Add GitHub Actions based publishing of the website using GitHub Actions as the publishing source for GitHub Pages.
2b726cb
to
12713fe
Compare
This is going to be a great example of deploying with Actions beyond what's available in the Quarto documentation. If this and #2 are merged I propose maintaining a separate branch that preserves docs/ and demonstrates what the repo with a deployment from docs/ would look like for the sake of the template remaining accessible to users of any skill level and familiarity with Pages & Quarto. Quarto/RMarkdown sites generally aren't deployed with Actions and docs/ is meant to be kept under version control in those cases. |
Uh oh. Can you link me to Quarto docs on this? I'll see some of the Quarto team at SciPy and can talk with them there, but at first glance it seems like the Quarto team is recommending things that the GitHub Actions teams would actively discourage as (if I understand correctly) support for |
Ahhhh, ok, this is good to know. This is just anecdotal, but I can't think of any cases where I've come across a repo or tutorial for Quarto sites (at least from the R user side of things) where folks didn't appear to be just locally rendering site content to docs/, pushing docs/, and then pointing Pages there. It's also the first method their docs cover. That's primarily why I chose to deploy the site that way rather than using Actions or
This template will be a great example of how to use Actions to deploy a survey results site, especially if |
Would it make sense to put some of the comments here about |
@matthewfeickert this all looks good. Thanks for deploying and testing on your own fork. |
I should collect my references and open up an Issue on GitHub to see where they are planning on going. |
@cranmer this branch should contain the additional config files needed to use Actions to deploy the site. I'm not able to test it out on this branch since I don't have permission to point Pages to a new URL for this repo for testing.
I tried this out with a more complex deployment elsewhere for a different site and it built successfully, so this should work.
Squash and merge commit message