Refactor DrawPlayerTrack #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tone marker in edtiro being too high. Always display marker in octave closest to current note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove several unused parameters, simplify the code and improve readability. This also fixes two long-standing problems.
The tone marker was previously always three or four halftones too high. It is now on the same height as what is actually sung.
Previously, the marker was shifted by one octave whenever a new one was entered, e.g. when going from a B2 to a C2, the marker would jump down by 11 halftones. This is changed to always be in the octave that is closer to the current note, i.e. at a distance of most 6 halftones above or below.