Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark edited file as dirty when selecting note #908

Merged

Conversation

DeinAlptraum
Copy link
Contributor

Previously, during editing, switching to a different note via right/left arrow keys adds an undoable entry, making the action revertible via Ctrl+Z and asking whether changes should be saved when quitting.

Previously, during editing, switching to a different note via right/left
arrow keys adds an undoable entry, making the action revertible via Ctrl+Z
and asking whether changes should be saved when quitting.
@barbeque-squared
Copy link
Member

Is there a similar fix applicable to when you up/down to a different sentence? Or did that already not count as undo history?

(sorry for the technically-unrelated question, I just don't have time to check it myself now and I hope it would be trivial for you. this is a great contribution regardless because I so hate it when it does that popup even though all I did was go to some specific line+note and play that a few times -- to check if GAP and BPM are set correctly cq sync up with my audio)

@DeinAlptraum
Copy link
Contributor Author

The up/down part already doesn't do this. I checked all occurrences of CopyToUndo, and as far as I could tell, it was only the arrow right/left that had this issue.

Also, should be unrelated either way, but could you rerun the failed Windows build?

@barbeque-squared
Copy link
Member

I didn't have time (or fpc) to check that when I commented, but yeah it works great now.

Dunno what's up with the Windows build, I restarted it and then it was fine (at least we can restart these unlike the appveyor ones)

@barbeque-squared barbeque-squared merged commit ef99cc2 into UltraStar-Deluxe:master Oct 7, 2024
5 checks passed
@DeinAlptraum DeinAlptraum deleted the fix-editor-dirty branch October 8, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants