Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light theme #2

Open
vladshcherbin opened this issue May 30, 2018 · 3 comments
Open

Add light theme #2

vladshcherbin opened this issue May 30, 2018 · 3 comments
Assignees
Milestone

Comments

@vladshcherbin
Copy link

It would be cool to have a light theme out of the box, there are a lot of white terminals. Currently it looks like this:

screen shot 2018-05-30 at 12 55 52

@Undre4m
Copy link
Owner

Undre4m commented May 31, 2018

It would be nice to have a couple of pre-built themes.
I'm thinking something like igniculus('light'),
'light' being the name of one of the available themes ofc...

I'll add it as a planned feature for next release. Default theme would remain the same so its non-breaking.

@Undre4m Undre4m self-assigned this May 31, 2018
@vladshcherbin
Copy link
Author

vladshcherbin commented May 31, 2018

@Undre4m maybe it's better to make it as an option, to be like the other options. Style related options to define in a nested group, smth like:

igniculus({
  theme: 'light',
  styles: {
    comments: { mode: 'dim', fg: 'white' },
    constants: { mode: 'dim', fg: 'red' },
    ...
  },
  prefix: ...,
  postfix: ...,
  output: ...
})

Yes, it's a breaking one, but a good one for a future run since more options may be needed later and now options are already in mess (styles, prefix, postfix, output together).

What do you think?

@Undre4m
Copy link
Owner

Undre4m commented May 31, 2018

@vladshcherbin yes, separation of style-related and option-specific configurations is something i've been wanting to do but haven't had the time. It's an issue for version 2.0, among others. Probably something like:

igniculus({
  prefix: {
    style: { fg: ... },
    options: {  text: ... }
  }
})

I do like the idea of a theme option, i think is the way to go; defining an optional pre-built theme to use, and being able to add/override specific options by the usual manner.

@Undre4m Undre4m added this to the 2.0 milestone May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants