Fix bug in GempakGrid #2904
Merged
Fix bug in GempakGrid #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A non-existent attribute GDTM2 was referenced when creating the Grid namedtuple. Since a majority of GEMPAK files do not define a second time on grids, it was not detected. That is, GDT2 is rarely defined and the logic statement gets terminated before actually checking for GDTM2. The parameter name was changed to the correct GTM2.
|
Thanks for sending in the fix! Would it be possible to add the file in question to our static data (assuming it's not huge) and add a corresponding test--even if it basically just checks that the file opens without error? |
|
Added a small test. Files will open, but having a second time assigned to a grid is not something that gets reflected in the |
dopplershift
approved these changes
Jan 27, 2023
dopplershift
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A non-existent attribute GDTM2 was referenced when creating the
Grid namedtuple. Since a majority of GEMPAK files do not define a
second time on grids, it was not detected. That is, GDT2 is rarely
defined and the logic statement gets terminated before actually checking
for GDTM2. The parameter name was changed to the correct GTM2.
Description Of Changes
Checklist