cmake: use add_compile_definitions

CMakeLists.txt

@@ -175,13 +175,10 @@ IF(NOT ENABLE_COVERAGE_TESTS)
   string(APPEND CMAKE_C_FLAGS " -O2")
 ENDIF()
 
-
-ADD_DEFINITIONS()
-
 # Supress CRT Warnings.
 # Only necessary for Windows
 IF(MSVC)
-  ADD_DEFINITIONS(-D_CRT_SECURE_NO_WARNINGS)
+  add_compile_definitions(_CRT_SECURE_NO_WARNINGS)
 ENDIF()
 
 
@@ -533,26 +530,26 @@ CHECK_INCLUDE_FILE("netcdf.h" HAVE_NETCDF_H)
 # End Check for various system header files.
 ###
 
-ADD_DEFINITIONS(-DNCSHORT_T=integer*2)
-ADD_DEFINITIONS(-DNCBYTE_T=byte)
-ADD_DEFINITIONS(-DNF_RELAX_COORD_BOUND)
-ADD_DEFINITIONS(-DNF_HAS_PARALLEL4)
-ADD_DEFINITIONS(-DNF_HAS_PNETCDF)
-#ADD_DEFINITIONS(-DENABLE_CDF5)
-ADD_DEFINITIONS(-DNF_INT1_IS_C_SIGNED_CHAR)
-#ADD_DEFINITIONS(-DNF_INT1_IS_C_SHORT)
-#ADD_DEFINITIONS(-DNF_INT1_IS_C_INT)
-#ADD_DEFINITIONS(-DNF_INT1_IS_C_LONG)
-ADD_DEFINITIONS(-DNF_INT2_IS_C_SHORT)
-#ADD_DEFINITIONS(-DNF_INT2_IS_C_INT)
-#ADD_DEFINITIONS(-DNF_INT2_IS_C_LONG)
-ADD_DEFINITIONS(-DNF_INT_IS_C_INT)
-#ADD_DEFINITIONS(-DNF_INT_IS_C_LONG)
-ADD_DEFINITIONS(-DNF_INT8_IS_C_LONG_LONG)
-ADD_DEFINITIONS(-DNF_REAL_IS_C_FLOAT)
-#ADD_DEFINITIONS(-DNF_REAL_IS_C_DOUBLE)
-ADD_DEFINITIONS(-DNF_DOUBLEPRECISION_IS_C_DOUBLE)
-#ADD_DEFINITIONS(-DNF_DOUBLEPRECISION_IS_C_FLOAT)
+add_compile_definitions(NCSHORT_T=integer*2)
+add_compile_definitions(NCBYTE_T=byte)
+add_compile_definitions(NF_RELAX_COORD_BOUND)
+add_compile_definitions(NF_HAS_PARALLEL4)
+add_compile_definitions(NF_HAS_PNETCDF)
+#add_compile_definitions(ENABLE_CDF5)
+add_compile_definitions(NF_INT1_IS_C_SIGNED_CHAR)
+#add_compile_definitions(NF_INT1_IS_C_SHORT)
+#add_compile_definitions(NF_INT1_IS_C_INT)
+#add_compile_definitions(NF_INT1_IS_C_LONG)
+add_compile_definitions(NF_INT2_IS_C_SHORT)
+#add_compile_definitions(NF_INT2_IS_C_INT)
+#add_compile_definitions(NF_INT2_IS_C_LONG)
+add_compile_definitions(NF_INT_IS_C_INT)
+#add_compile_definitions(NF_INT_IS_C_LONG)
+add_compile_definitions(NF_INT8_IS_C_LONG_LONG)
+add_compile_definitions(NF_REAL_IS_C_FLOAT)
+#add_compile_definitions(NF_REAL_IS_C_DOUBLE)
+add_compile_definitions(NF_DOUBLEPRECISION_IS_C_DOUBLE)
+#add_compile_definitions(NF_DOUBLEPRECISION_IS_C_FLOAT)
 
 ###
 # Type checks
@@ -651,7 +648,7 @@ CHECK_C_SOURCE_COMPILES("
 #endif
 int main() {return 0;}" HAVE_QUANTIZE)
 if (HAVE_QUANTIZE)
-   ADD_DEFINITIONS(-DNF_HAS_QUANTIZE)
+   add_compile_definitions(NF_HAS_QUANTIZE)
 endif()
 
 CHECK_LIBRARY_EXISTS(${NETCDF_C_LIBRARY} nc_def_var_szip "" HAVE_DEF_VAR_SZIP)
@@ -743,12 +740,12 @@ ENDIF(BUILD_DAP)
 SET(ENABLE_NETCDF4 OFF)
 IF(USE_NETCDF4)
   SET(ENABLE_NETCDF4 ON)
-  ADD_DEFINITIONS(-DUSE_NETCDF4)
+  add_compile_definitions(USE_NETCDF4)
   SET(ENABLE_NETCDF4 ON CACHE BOOL "")
 ENDIF()
 
 IF (UNIX AND ${CMAKE_SIZEOF_VOID_P} MATCHES "8")
-  ADD_DEFINITIONS(-DLONGLONG_IS_LONG)
+  add_compile_definitions(LONGLONG_IS_LONG)
   # for easier debugging of cfortran.h
   IF (APPLE)
     IF(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
@@ -782,10 +779,10 @@ try_compile(NF_HAS_PARALLEL4 ${CMAKE_CURRENT_BINARY_DIR}
   )
 
 IF(NF_HAS_PARALLEL4)
-  ADD_DEFINITIONS(-DNF_HAS_PARALLEL4)
+  add_compile_definitions(NF_HAS_PARALLEL4)
 ENDIF()
 IF(NF_HAS_PNETCDF)
-  ADD_DEFINITIONS(-DNF_HAS_PNETCDF)
+  add_compile_definitions(NF_HAS_PNETCDF)
 ENDIF()
 
 IF(NF_HAS_PNETCDF OR NF_HAS_PARALLEL4)
@@ -813,7 +810,7 @@ try_compile(COMPILE_SUCCESS ${CMAKE_CURRENT_BINARY_DIR}
   "${CMAKE_CURRENT_SOURCE_DIR}/CMakeExtras/test_c_ptrdiff_t.f90"
   )
 IF (COMPILE_SUCCESS)
-  ADD_DEFINITIONS(-DHAVE_TS29113_SUPPORT)
+  add_compile_definitions(HAVE_TS29113_SUPPORT)
   SET(HAVE_TS29113_SUPPORT TRUE)
 ELSE ()
   # If the compile fails, PTRDIFF_T is not defined.
@@ -832,7 +829,7 @@ ELSE ()
     IF (SIZEOF_RESULT)
       MESSAGE (FATAL_ERROR "UNABLE TO DETERMINE SIZEOF PTRDIFF_T")
     ELSE (SIZEOF_RESULT)
-      ADD_DEFINITIONS(-DSIZEOF_PTRDIFF_T=${SIZEOF_PTRDIFF_T})
+      add_compile_definitions(SIZEOF_PTRDIFF_T=${SIZEOF_PTRDIFF_T})
     ENDIF (SIZEOF_RESULT)
   ELSE()
     MESSAGE(FATAL_ERROR "Unable to compile ptrdiff")