Merge pull request #1352 from ocefpaf/inspect_deprecation_warnings

Inspect deprecation warnings

.github/workflows/miniconda.yml

@@ -45,7 +45,7 @@ jobs:
 
     - name: Tests
       run: |
-        cd test && python run_all.py
+        pytest -s -rxs -v test
 
   run-mpi:
     runs-on: ${{ matrix.os }}

pyproject.toml

@@ -77,6 +77,10 @@ where = ["src"]
 
 [tool.pytest.ini_options]
 pythonpath = ["test"]
+filterwarnings = [
+    "error",
+    "ignore::UserWarning",
+]
 
 [tool.mypy]
 files = ["src/netCDF4"]

src/netCDF4/_netCDF4.pyx

@@ -5315,7 +5315,7 @@ rename a `Variable` attribute named `oldname` to `newname`."""
             # corresponds to missing values, don't fill masked array -
             # just use underlying data instead
             if hasattr(self, 'missing_value') and \
-               numpy.all(numpy.in1d(data.data[data.mask],self.missing_value)):
+               numpy.all(numpy.isin(data.data[data.mask],self.missing_value)):
                 data = data.data
             else:
                 if hasattr(self, 'missing_value'):

test/test_dap.py

@@ -7,7 +7,7 @@
 
 # test accessing data over http with opendap.
 
-yesterday = datetime.utcnow() - timedelta(days=1)
+yesterday = datetime.now() - timedelta(days=1)
 URL = f'http://nomads.ncep.noaa.gov/dods/gfs_1p00/gfs{yesterday:%Y%m%d}/gfs_1p00_00z'
 URL_https = 'https://www.neracoos.org/erddap/griddap/WW3_EastCoast_latest'
 varname = 'hgtsfc'

test/test_stringarr.py

@@ -41,7 +41,7 @@ def setUp(self):
         v2[:-1] = data[:-1]
         v2[-1] = data[-1]
         v2[-1,-1] = data[-1,-1] # write single element
-        v2[-1,-1] = data[-1,-1].tostring() # write single python string
+        v2[-1,-1] = data[-1,-1].tobytes() # write single python string
         # _Encoding should be ignored if an array of characters is specified
         v3[:] = stringtochar(data, encoding='ascii')
         nc.close()

test/test_types.py

@@ -68,7 +68,7 @@ def runTest(self):
                 #assert np.allclose(datarr, ranarr[1:n1dim].astype(data.dtype))
                 assert_array_almost_equal(datarr,ranarr[1:n1dim].astype(data.dtype))
             else:
-                assert datarr.tostring() == ranarr[1:n1dim].astype(data.dtype).tostring()
+                assert datarr.tobytes() == ranarr[1:n1dim].astype(data.dtype).tobytes()
             # check that variable elements not yet written are filled
             # with the specified _FillValue.
             assert_array_equal(datfilled,np.asarray(data._FillValue,datfilled.dtype))