Fixed bug with optional field operation: AgentJava crashed if it was …

…missing (#11)
Unikie · Jul 11, 2016 · 886c0b2 · 886c0b2
1 parent e4601e9
commit 886c0b2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/main/java/io/aino/agents/core/validators/OperationValidator.java b/src/main/java/io/aino/agents/core/validators/OperationValidator.java
@@ -39,7 +39,7 @@ public OperationValidator(AgentConfig conf) {
 
     @Override
     public void validate(Transaction entry) {
-        if(!config.getOperations().entryExists(entry.getOperationKey()))
+        if(null != entry.getOperationKey() && !config.getOperations().entryExists(entry.getOperationKey()))
             throw new AgentCoreException("Operation does not exist: " + entry.getOperationKey());
     }
 }
diff --git a/src/test/unit/java/io/aino/agents/core/validators/OperationValidatorTest.java b/src/test/unit/java/io/aino/agents/core/validators/OperationValidatorTest.java
@@ -35,6 +35,15 @@ public void setUp() {
                 .build();
     }
 
+    @Test
+    public void testDoesNotThrowWithMissingOperation() {
+        Transaction tle = new Transaction(agent.getAgentConfig());
+        tle.setFromKey("esb");
+        tle.setToKey("app01");
+
+        agent.addTransaction(tle);
+    }
+
     @Test
     public void testDoesNotThrowWithValidOperation() {
         Transaction tle = new Transaction(agent.getAgentConfig());