Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split pool event handlers #213

Merged
merged 4 commits into from
Apr 12, 2024
Merged

split pool event handlers #213

merged 4 commits into from
Apr 12, 2024

Conversation

mzywang
Copy link
Collaborator

@mzywang mzywang commented Apr 3, 2024 •
edited
Loading

simply splits up the core handlers, this is to clean up the code before adding the collect event handler

also updates/adds three scripts to the package.json for development

@socket-security Socket Security
Copy link

socket-security bot commented Apr 3, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment Transitive: filesystem, shell +32 528 kB mysticatea

View full report↗︎

cgkol
cgkol approved these changes Apr 6, 2024
View reviewed changes
Copy link

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one smol quesiton but not a blocker

subgraph.yaml Show resolved Hide resolved
@mzywang mzywang changed the title split core handlers split pool event handlers Apr 8, 2024
@mzywang mzywang merged commit 4fda7e3 into main Apr 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgkol cgkol cgkol approved these changes

@ianlapham ianlapham ianlapham approved these changes

@andysmith415 andysmith415 Awaiting requested review from andysmith415

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzywang @ianlapham @cgkol