CMCL-1634: decollider would sometimes cause camera to slip inside cracks between adjacent colliders

[glabute]

Purpose of this PR

CMCL-1634: decollider would sometimes cause camera to slip inside cracks between adjacent colliders

This is because the collider detection algorithm was inadequate. Algorithm was reworked to be more robust around colliders made up of multiple adjacent colliders. Camera will only go into the crack if the crack is wider than the camera radius specified in the Decollider.

Bonus: smoothing logic was also simplified and corrected, fixing an intermittent bug that caused the camera to sometimes snap out of its smoothed position, bypassing damping. That bug was unreported.

Testing status

• Added an automated test
• Passed all automated tests
• Manually tested

Documentation status

• Updated CHANGELOG
• Updated README (if applicable)
• Commented all public classes, properties, and methods
• Updated user documentation

Technical risk

low

Comments to reviewers

Please see test scene in the Jira ticket.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (ba4cc2b) to head (c6b10f0).
Report is 78 commits behind head on main.

Files with missing lines	Patch %	Lines
...achine/Runtime/Behaviours/CinemachineDecollider.cs	0.00%	50 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
+ Coverage   26.97%   27.21%   +0.24%     
==========================================
  Files         254      254              
  Lines       28418    28485      +67     
==========================================
+ Hits         7665     7753      +88     
+ Misses      20753    20732      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sebastienduverne]

Minor things in Changelog.

[alexzaranek]

Small nitpick but would it be possible to avoid instantiating this buffer and instead sort the colliders in distance order directly in the s_ColliderBuffer? Using Array.Sort(s_ColliderDistanceBuffer, s_ColliderBuffer) should sort both buffers in the distance order.

[alexzaranek]

Other than that small nitpick, I've tested the changes and the camera decollider now works as expected.