Update SSR instructions in README.md #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use server-side SDK instead of client-side
Tymek
requested changes
Mar 6, 2024
There was a problem hiding this comment.
My understanding is that server-side code such as getServerSideProps should be using Unleash's server-side SDK, not the client-side SDK implemented in unleash-proxy-client... (right?)
It can use either Unleash Server Client or Unleash Frontend Client. Example above (SSG) is using Server Client (definitions). I like the idea of changing SSR example to the same code as SSG.
README.md
Outdated
|
|
||
| return { | ||
| props: { | ||
| isEnabled: flags.isEnabled("nextjs-example"), | ||
| // Or you can skip the flagsClient and access the toggles directly, but this will skip impression logging | ||
| // and other client logic from unleash-proxy-client | ||
| isEnabled: toggles.find((t) => t.name === 'FEATURE_NAME').enabled |
There was a problem hiding this comment.
This can be misleading. It's not a result of evaluation. This is from definitions. Feature can be enabled in definitions and still evaluate strategies to false.
There was a problem hiding this comment.
Ooooh! Okay, I was confused about that - I'll just remove this...
This suggestion would not have properly evaluated the flags based on specified strategies.
Tymek
approved these changes
Mar 7, 2024
renovate bot
referenced
this pull request
in simonknittel/simonknittel.de
Apr 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@unleash/nextjs](https://togithub.com/Unleash/unleash-client-nextjs) | [`1.4.1` -> `1.4.2`](https://renovatebot.com/diffs/npm/@unleash%2fnextjs/1.4.1/1.4.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Unleash/unleash-client-nextjs (@​unleash/nextjs)</summary> ### [`v1.4.2`](https://togithub.com/Unleash/unleash-client-nextjs/releases/tag/v1.4.2) [Compare Source](https://togithub.com/Unleash/unleash-client-nextjs/compare/v1.4.1...v1.4.2) #### What's Changed - Update SSR instructions in README.md by [@​mltsy](https://togithub.com/mltsy) in [https://github.com/Unleash/unleash-client-nextjs/pull/66](https://togithub.com/Unleash/unleash-client-nextjs/pull/66) - fix: variant stickiness by [@​Tymek](https://togithub.com/Tymek) in [https://github.com/Unleash/unleash-client-nextjs/pull/70](https://togithub.com/Unleash/unleash-client-nextjs/pull/70) **Full Changelog**: Unleash/unleash-client-nextjs@v1.4.1...v1.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/simonknittel/simonknittel.de). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->
](https://renovatebot.com){kind=link}
renovate bot
referenced
this pull request
in simonknittel/sinister-incorporated
Apr 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@unleash/nextjs](https://togithub.com/Unleash/unleash-client-nextjs) | [`1.4.1` -> `1.4.2`](https://renovatebot.com/diffs/npm/@unleash%2fnextjs/1.4.1/1.4.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Unleash/unleash-client-nextjs (@​unleash/nextjs)</summary> ### [`v1.4.2`](https://togithub.com/Unleash/unleash-client-nextjs/releases/tag/v1.4.2) [Compare Source](https://togithub.com/Unleash/unleash-client-nextjs/compare/v1.4.1...v1.4.2) #### What's Changed - Update SSR instructions in README.md by [@​mltsy](https://togithub.com/mltsy) in [https://github.com/Unleash/unleash-client-nextjs/pull/66](https://togithub.com/Unleash/unleash-client-nextjs/pull/66) - fix: variant stickiness by [@​Tymek](https://togithub.com/Tymek) in [https://github.com/Unleash/unleash-client-nextjs/pull/70](https://togithub.com/Unleash/unleash-client-nextjs/pull/70) **Full Changelog**: Unleash/unleash-client-nextjs@v1.4.1...v1.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/simonknittel/sinister-incorporated). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use server-side SDK instead of client-side
About the changes
My understanding is that server-side code such as getServerSideProps should be using Unleash's server-side SDK, not the client-side SDK implemented in unleash-proxy-client... (right?)
Important files
Discussion points
In reality, I think that this scenario should be leveraging the
unleash-clientNode SDK package, rather than any of the client-side types (i.e.IToggle) or functionality provided by theunleash-proxy-clientfrontend package. Which we could provide an example for here, but ideally this library should wrap that in something that defaults to using the same environment variables to configure a client, and maintain a singleton instance for you, etc.Using the Node client on the server-side would allow the app to have a singleton client instance that syncs itself with the Unleash server periodically, as recommended by the Unleash docs, and the user would only need to import that client and call
isEnabledas needed, passing in a relevant context. I guess that's all being discussed in #45. For now, this PR at least demonstrates how to utilize the server-side SDK for server-side code.